storage: improve TestSystemZoneConfigs #41119
Merged
+7
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failure mode in cockroachdb#40980 didn't give out any actionable information. It now prints the mismatching descriptors. Release justification: testing-only improvement. Release note: None
|
This change is |
danhhz
approved these changes
Sep 26, 2019
|
bors r=danhhz TC flake was being unable to contact github.com |
craig bot
pushed a commit
that referenced
this pull request
Sep 27, 2019
41119: storage: improve TestSystemZoneConfigs r=danhhz a=tbg The failure mode in #40980 didn't give out any actionable information. It now prints the mismatching descriptors. With this commit (and at this SHA) we see within a few minutes ``` make stress PKG=./pkg/storage/ TESTS=TestSystemZoneConfigs --- FAIL: TestSystemZoneConfigs (61.72s) client_replica_test.go:1749: condition failed to evaluate within 45s: mismatch between r1:/{Min-System/NodeLiveness} [(n2,s2):8, (n7,s7):2, (n5,s5):3, (n6,s6):4, (n3,s3):6, next=9, gen=17] r1:/{Min-System/NodeLiveness} [(n1,s1):1, (n7,s7):2, (n5,s5):3, (n6,s6):4, (n3,s3):6, (n4,s4):7LEARNER, next=8, gen=12] ``` Release justification: testing-only improvement. Release note: None Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure mode in #40980 didn't give out any actionable information.
It now prints the mismatching descriptors.
With this commit (and at this SHA) we see within a few minutes
Release justification: testing-only improvement.
Release note: None